Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplyEffect implementation #1688

Draft
wants to merge 42 commits into
base: master
Choose a base branch
from
Draft

ApplyEffect implementation #1688

wants to merge 42 commits into from

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented Sep 7, 2024

No description provided.

@heinezen heinezen added nice new thing ☺ A new feature that was not there before lang: c++ Done in C++ code area: simulation Involved in the game mechanics and simulation big stuff High-impact changes, mainly foundation work labels Sep 7, 2024
@heinezen heinezen force-pushed the feature/apply_effect branch 2 times, most recently from fe0e630 to 5b96a18 Compare September 8, 2024 19:59
@heinezen heinezen force-pushed the feature/apply_effect branch from 03fd671 to 61d409b Compare October 5, 2024 19:32
@heinezen heinezen force-pushed the feature/apply_effect branch from 8449c6d to 51416c3 Compare October 15, 2024 01:46
@heinezen heinezen added the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Oct 20, 2024
@SFTbot SFTbot removed the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Oct 20, 2024
@heinezen heinezen force-pushed the feature/apply_effect branch 3 times, most recently from d79f834 to 26bac42 Compare November 5, 2024 04:17
@heinezen heinezen force-pushed the feature/apply_effect branch from 30c0ef0 to 35d4f37 Compare November 18, 2024 22:46
heinezen added 16 commits December 2, 2024 04:37
@heinezen
gamestate: Apply*Effect components.
f9fd7ce
@heinezen
gamestate: Create Apply*Effect components for new entities.
88a8d5f
@heinezen
gamestate: API interface for Apply*Effect abilities.
99a8431
@heinezen
gamestate: Fix checking ability parents.
45e9523
@heinezen
gamestate: Add Resistance component.
5f6822e
@heinezen
gamestate: Add basic system skeleton for applying effects.
736a60e
@heinezen
gamestate: resistance definitions.
198d848
@heinezen
gamestate: API layer for nyan effects.
2e477cc
@heinezen
gamestate: API layer for nyan resistances.
f908c9c
@heinezen
gamestate: Add LineOfSight component.
1d825d0
@heinezen
gamestate: LineOfSight definitions.
cb31486
@heinezen
gamestate: Add missing definitions for already implemented abilities.
c69e0c1
@heinezen
gamestate: Allow fractional values for attributes.
01c2823
@heinezen
gamestate: Calculate application for discrete FLAC effects.
aafc6fb
@heinezen
gamestate: Decrease log level of unrecognized components.
ad572b4
@heinezen
gamestate: ApplyEffect command.
d98e69f
heinezen added 26 commits December 2, 2024 04:37
@heinezen
gamestate: Rename command classes and make them 'final'.
4b679c5
@heinezen
gamestate: Add condition for ApplyEffect command in activity system.
142240f
@heinezen
convert: Add new activity conditions for applying effects.
8ccd814
@heinezen
gamestate: Handle ApplyEffect in activity system.
4e58446
@heinezen
gamestate: Fix time calculations for applying effects.
ced1ee0
@heinezen
gamestate: Move animation property handling to helper function.
fee671d
@heinezen
gamestate: Animate effect application.
d508a5b
@heinezen
curve: Add compress argument for curve operations.
27ad344
@heinezen
curve: Rename argument for keyframes to 'keyframe'.
2e4c568 
Distinguishes it from the other methods that pass 'time' and 'value' to construct a new keyframe.
@heinezen
curve: Compress operation on keyframe insertion.
7b23eec
@heinezen
curve: Compress method for curves.
486d6df
@heinezen
curve: Add new unit tests for compress() method.
0c071ba
@heinezen
curve: Fix compression method.
b3df48a
@heinezen
curve: Pass through compression args.
bbb697f
@heinezen
curve: Compress during curve sync.
ba2c3ad
@heinezen
renderer: Compress sync on animations curve.
c017074
@heinezen
renderer: Make fetching from render entity more reliable.
6073e25
@heinezen
curve: Fix compilation for oider clang versions.
ae6b8c3
@heinezen
curve: Concept for curve values.
ce7242d
@heinezen
doc: Add documentation for curve compression.
87e7ebe
@heinezen
gamestate: Add activity node type for branching on value.
4444284
@heinezen
gamestate: Handle XorSwichGate in activity system.
9878f65
@heinezen
gamestate: Add unit tests for activity node types.
a8709de
@heinezen
gamestate: Make a lookup function for next comand switching.
0253022
@heinezen
convert: Use new switch gate for command branching.
754ad80
@heinezen
gamestate: Init new XorSwitchGate activity node type from nyan.
63bc382
@heinezen heinezen force-pushed the feature/apply_effect branch from 35d4f37 to 63bc382 Compare December 2, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: simulation Involved in the game mechanics and simulation big stuff High-impact changes, mainly foundation work lang: c++ Done in C++ code nice new thing ☺ A new feature that was not there before
Projects
openage game simulation
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heinezen @SFTbot